Substitute-h2k.rb: Improve foundation upgrades

[jblake59]

The current foundation upgrade option allows for:

1. Changing the insulation configuration specification within a foundation type (e.g., BCIN_1 to BCEA_3) but not allowing the type to be changed (i.e., the "B" in this case)
2. Changing the wall and/or slab insulation of foundations that match the foundation type (i.e., B, W, C or S).

Note that the tag 1 code in "Opt-H2KFoundation" is a concatenation of the configuration type (e.g., BCIN_1) and one of the following suffixes:

• _ALL: Change insulation in all foundation types (Basement, Walkout, Crawlspace & Slab-On-Grade)
• _B: Change insulation in all Full Basements only
• _W: Change insulation in all Walkouts only
• _C: Change insulation in all Crawlspaces only
• _S: Change insulation in all Slab-On-Grade foundations only

Example: BCIN_1_B This is documented in tag "Opt-H2KFoundation" of the HOT2000.options file and in HTAP/doc/HTAP-input-and-output.md.

It does NOT:

1. Change the insulation configuration of both Basement and Slab foundations in a file (e.g., change insulation in Basements to BCIN_1 and Slabs to SCN_1).
2. Change the insulation in a specific (single) foundation entry
3. Change the basic foundation type (e.g., Basement to a Slab).

This issue is primarily concerned with resolving the first restriction.

[jblake59]

Proposal 1 Leave "Opt-H2KFoundation" as-is (handles B, W, C or S) and add a second foundation option named "Opt-H2KFoundationSlabOrCrawl" that handles only Slab-On-Grade or Crawlspace foundations. This approach allows existing choice files to run without change but allows new choice files to create two sets of upgrades -- one for "basements" (i.e., foundations that are designated as either B or W) and another for Slab/Crawl foundations (S or C -- code currently deals with both Slabs and Crawlspaces together because XML structure is the same!).

Note: The following potential issue may arise from this approach:

• "Opt-H2KFoundation" could accidentally specify a "S" or "C" foundation in addition to the new option "Opt-H2KFoundationSlabOrCrawl"! This could lead to uncertain results, depending on order of application. I will test what happens and document.

[jblake59]

Proposal 2 Modify "Opt-H2KFoundation" so it handles all foundation types (i.e., B, W, C or S). This is a fairly significant change to the Ruby script that involves:

• Handling different XML formats. Foundations B and W have the same XML format but it is different than the XML format for foundations C and S. This is handled now but the logic would need to change.
• B & W foundations both use configuration codes starting with "B" but crawlspace and slabs use different configuration codes. I would need to map the requested configuration code to an equivalent for the other foundations.

Note that this still restricts us to one foundation upgrade specification and it would not be obvious (and sometimes impossible) to choose one configuration that effects all foundations as desired!

[jblake59]

Proposal 1 implemented.