NRCan / CanFlood

Flood Risk modelling toolbox for Canada

MIT License

29 stars 7 forks source link

Feature - Results - Added page numbers and page headers to each section during report creation #39

Closed BenMaxIBI closed 2 years ago

BenMaxIBI commented 2 years ago

CanFlood

Changelog:

Added page numbers with function add_page_number
Added page headers with function add_page_header
Corrected stretched text on report template

Test coverage for this change

[ ] I have added API unit tests
[ ] I have added appropriate UI unit tests (ng component or cypress)
[X] I have not added tests

cefect commented 2 years ago

Thanks @BenMaxIBI , this procedure worked well from my end... nice and clean. I'm not sure how best to handle the test development as this is sort of a mess right now... so I guess we'll sort that later. looking forward to your other PRs.