NRCan / CanFlood

Flood Risk modelling toolbox for Canada

MIT License

29 stars 7 forks source link

feature: Added Damage curves plot as new section #53

Closed BenMaxIBI closed 2 years ago

BenMaxIBI commented 2 years ago

CanFlood

Changelog:

Getting curves filepath from control file
New method in dialog to plot using existing plot methods
Shifted legend underneath plot for better readability

Test coverage for this change:

[ ] I have added API unit tests
[ ] I have added appropriate UI unit tests
[X] I have not added tests

Additional Notes:

cefect commented 2 years ago

Thanks @BenMaxIBI, this looks great. We may need to add a 'purge curves' tool at some point (to the Build), but this can be done later. I made some tweaks to some of your variable and function names ( I use the 'run' prefix for something tied to a GUI button. I like to include some description of the object type in variable names where possible)