search

NRCan / CanFlood

Flood Risk modelling toolbox for Canada
MIT License
28 stars 7 forks source link

fX_tag got nulls | IBI 2020 Curves | FBC Dataset #89

Closed akhilk15 closed 1 year ago

akhilk15 commented 1 year ago

Hi, I am working with IBI 2020 curves and FBC CanFlood building datasets. The asset inventory dataset has "null" values assigned to some of the assets (in f2_tag, f3_tag, f4_tag). I guess the intention was to tell CanFlood that no curve has been assigned to these assets. I am not doing any edits to the dataset, but when I run the CanFlood model, I am getting a python error that says "f2_tag got nulls...see logger". Can you please guide me on how to fix it? Thanks! image

akhilk15 commented 1 year ago

Please see the asset inventory dataset screenshot. You can see NULL value assigned to some of the assets in fX_tag category. image

cefect commented 1 year ago

Thank you for the question. Did you try assigning an arbitrary curve to these, then set fx_scale to zero?

Let me know if this works for you,

akhilk15 commented 1 year ago

Hi @cefect , thank you for your help. This trick works. But now there is another issue. Because I can only select one depth-damage curve at a time from the library, Python is giving an error that it could not load other requested dfuncs. As you can see in the asset inventory screenshot above, multiple curves have been referenced. Is there a way I can select load multiple dfuncs at the same time?

akhilk15 commented 1 year ago

image

cefect commented 1 year ago

are all of the curves you've specified in the inventory included in the curves.xls file?

akhilk15 commented 1 year ago

actually, the IBI2020 curves are split into different categories, as you can see in the screenshot below. I can only select only one Excel sheet at a time. There is no single Excel sheet that has all the curves. It seems like I will have to run the analysis for each curve one by one. Any suggestions please? image

cefect commented 1 year ago

The vFunc library tool is for quickly building models. If you want to mix curves from different libraries, you'll have to merge all the tabs into one spreadsheet. This is easy to do in Excel (right click tab > move or copy...). There was some discussion on including a merge feature like this into CanFlood, but such a feature has not been implemented.

akhilk15 commented 1 year ago

Thank you, @cefect. I was able to create one compiled spreadsheet and it worked. I may have some other questions later on. But I think I am good for now. Our group will be using this tool more extensively moving on. If you like, I can share more about our learnings and the need for any feature updates necessary to further advance this tool. Thanks! Akhil Kumar, P.Eng., City of Vancouver.