NRCan / geo-deep-learning

Deep learning applied to georeferenced datasets
https://geo-deep-learning.readthedocs.io/en/latest/
MIT License
149 stars 49 forks source link

Srping cleaning for parameters - get_key_def edition #479

Open CharlesAuthier opened 1 year ago

CharlesAuthier commented 1 year ago

After changing the get_key_def function, I notice some get_key_def function with the parameter to_path=True have also the parameter expected_type=str but with the new modification those one need to be change to expected_type=Path. Some of them like line 373 in inference segmentation or the line 366 of the same function are not flag in the test since their value are None, a option will be to raise a message if the parameter expected_type is not a path when to_path=True.

Also, a lot of change have been done recently, we need to take a look at all the parameters that are call but not use or dont have any value .