NRCan / geo-deep-learning

Deep learning applied to georeferenced datasets
https://geo-deep-learning.readthedocs.io/en/latest/
MIT License
150 stars 49 forks source link

553 feature refactor segmentationdataset class #554

Closed valhassan closed 6 months ago

valhassan commented 6 months ago

Thank you for submitting your PR and helping us with GDL. Please read the template below, fill it out as appropriate, and make additional changes to your code as needed. Please feel free to submit your PR even if it doesn't satisfy all of the requirements below. If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively. After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.

Description

Fixes #553

Type of change

What types of changes does your code introduce? Put an x in all the boxes that apply:

How Has This Been Tested?

added unit test for SegmentionDataset class

Screenshots (if applicable):

Checklist:

If you're unsure about any of these, don't hesitate to ask. We're here to help!

If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

remtav commented 6 months ago

nicely done. What was the initial motivation for this refactoring @valhassan ? Adding a test :) ?