codecov[bot]
commented
3 years ago Codecov Report
Merging #178 (f591e5d) into master (150aa6b) will increase coverage by
0.86%. The diff coverage is88.88%.
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 70.02% 70.89% +0.86%
==========================================
Files 42 42
Lines 2622 2628 +6
==========================================
+ Hits 1836 1863 +27
+ Misses 786 765 -21 | Flag | Coverage Δ | |
|---|---|---|
| unittests | 70.89% <88.88%> (+0.86%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/system_data.jl | 87.70% <88.88%> (+5.73%) |
:arrow_up: |
| src/time_series_container.jl | 53.65% <0.00%> (-4.88%) |
:arrow_down: |
| src/deterministic_single_time_series.jl | 74.07% <0.00%> (+1.85%) |
:arrow_up: |
| src/component.jl | 92.42% <0.00%> (+6.49%) |
:arrow_up: |
This PR addresses an issue where running
transform_single_time_seriesmore than once fails. The new functionality changes the behavior of some of the negative tests, so they have been adjusted.There is a related issue of adding a new time_series after
transform_single_time_serieshas already been executed. This partially addresses that issue by allowing the user to executeclear_time_series_transformation!, then adding the new time series, and then runningtransform_single_time_series. But I can address that more concisely after feedback on this approach.I believe that @sourabhdalvi, @Nongchao, @ugirumurera, and @andrewrosemberg may all be interested in this.