NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/stable/
BSD 3-Clause "New" or "Revised" License
39 stars 21 forks source link

apply removal correctly #183

Closed jd-lara closed 3 years ago

jd-lara commented 3 years ago

Fixes a bug introduced in 77d857c1a2c6639e06b082701c6e4f06439eb796 that removes the data for all time forecast always.

There is one drawback to this approach. If a second call for transform is made and it has inadequate parameters then the correct transformation that was stored before will be eliminated.

codecov[bot] commented 3 years ago

Codecov Report

Merging #183 (4d60fe2) into master (07bef7f) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   70.89%   70.91%   +0.02%     
==========================================
  Files          42       42              
  Lines        2628     2630       +2     
==========================================
+ Hits         1863     1865       +2     
  Misses        765      765              
Flag Coverage Δ
unittests 70.91% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/system_data.jl 87.84% <100.00%> (+0.13%) :arrow_up:
src/time_series_parameters.jl 92.20% <100.00%> (ø)