codecov[bot]
commented
3 years ago Codecov Report
Merging #200 (f40866c) into master (23ef047) will decrease coverage by
3.30%. The diff coverage is34.37%.
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 75.02% 71.71% -3.31%
==========================================
Files 42 42
Lines 2995 2698 -297
==========================================
- Hits 2247 1935 -312
- Misses 748 763 +15 | Flag | Coverage Δ | |
|---|---|---|
| unittests | 71.71% <34.37%> (-3.31%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/deterministic_metadata.jl | 5.00% <0.00%> (-95.00%) |
:arrow_down: |
| src/serialization.jl | 44.44% <ø> (-6.06%) |
:arrow_down: |
| src/generated/DeterministicMetadata.jl | 52.17% <50.00%> (-8.70%) |
:arrow_down: |
| src/component.jl | 92.64% <100.00%> (-0.92%) |
:arrow_down: |
| src/time_series_utils.jl | 100.00% <100.00%> (ø) |
|
| src/utils/assert_op.jl | 44.44% <0.00%> (-13.89%) |
:arrow_down: |
| src/utils/test.jl | 42.30% <0.00%> (-7.70%) |
:arrow_down: |
| src/single_time_series.jl | 59.74% <0.00%> (-7.29%) |
:arrow_down: |
| src/time_series_container.jl | 53.65% <0.00%> (-6.76%) |
:arrow_down: |
| src/internal.jl | 70.73% <0.00%> (-5.87%) |
:arrow_down: |
| ... and 29 more |
This fixes a bug that caused the function to return instances of Deterministic when the caller asked for DeterministicSingleTimeSeries. There was ambiguity in the mapping of DeterministicMetadata to the actual time series type. This change makes the mapping explicit.