NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
39 stars 20 forks source link

Fix transform_time_series when interval and resolution are equal #212

Closed daniel-thom closed 3 years ago

daniel-thom commented 3 years ago

Fixes #211

The previous checks for forecast count == 1 and interval == 0 were invalid.

jd-lara commented 3 years ago

The PR looks good, but it seems to have broken serialization.

codecov[bot] commented 3 years ago

Codecov Report

Merging #212 (2170fcd) into master (0789221) will increase coverage by 0.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   74.69%   74.85%   +0.16%     
==========================================
  Files          42       42              
  Lines        3027     3019       -8     
==========================================
- Hits         2261     2260       -1     
+ Misses        766      759       -7     
Flag Coverage Δ
unittests 74.85% <100.00%> (+0.16%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/component.jl 93.56% <ø> (-0.03%) :arrow_down:
src/utils/utils.jl 60.33% <100.00%> (-0.34%) :arrow_down:
src/InfrastructureSystems.jl 60.00% <0.00%> (-6.67%) :arrow_down:
src/internal.jl 74.46% <0.00%> (-2.13%) :arrow_down:
src/utils/lazy_dict_from_iterator.jl 96.15% <0.00%> (-0.15%) :arrow_down:
src/utils/print.jl 36.70% <0.00%> (+3.37%) :arrow_up:
src/common.jl 50.00% <0.00%> (+25.00%) :arrow_up:
daniel-thom commented 3 years ago

The PR looks good, but it seems to have broken serialization.

I don't understand the failure, but I'm confident that it was unrelated to the changes in this PR. I reran the tests and they passed. After that I made a new commit to get more test coverage.