NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
39 stars 20 forks source link

Fix transform_single_time_series with multiple forecasts on a component #216

Closed daniel-thom closed 3 years ago

daniel-thom commented 3 years ago

The code was mutating a dictionary while iterating over it. This caused it to try to transform one forecast twice.

codecov[bot] commented 3 years ago

Codecov Report

Merging #216 (e2586f0) into master (6486adb) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   74.92%   74.86%   -0.06%     
==========================================
  Files          42       42              
  Lines        3023     3020       -3     
==========================================
- Hits         2265     2261       -4     
- Misses        758      759       +1     
Flag Coverage Δ
unittests 74.86% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/component.jl 93.58% <100.00%> (+0.02%) :arrow_up:
src/InfrastructureSystems.jl 60.00% <0.00%> (-6.67%) :arrow_down:
src/internal.jl 74.46% <0.00%> (-2.13%) :arrow_down:
src/utils/utils.jl 60.33% <0.00%> (-0.85%) :arrow_down:
src/utils/lazy_dict_from_iterator.jl 96.15% <0.00%> (-0.15%) :arrow_down:
src/common.jl 50.00% <0.00%> (+25.00%) :arrow_up: