search

NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
39 stars 20 forks source link

Ambiguities in the code #226

Closed jd-lara closed 3 years ago

jd-lara commented 3 years ago

I have disabled the ambiguity tests in IS runtests.jl but these are the detected ones. 

Ambiguity #1
deserialize(::Type{T}, data::Dict) where T<:InfrastructureSystems.InfrastructureSystemsType in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/serialization.jl:132
deserialize(::Type{InfrastructureSystems.SystemData}, raw; time_series_read_only, time_series_directory) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/system_data.jl:555

Ambiguity #2
(::InfrastructureSystems.var"#get_window##kw")(::Any, ::typeof(InfrastructureSystems.get_window), forecast::InfrastructureSystems.Forecast, index::Int64) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/forecasts.jl:64
(::InfrastructureSystems.var"#get_window##kw")(::Any, ::typeof(InfrastructureSystems.get_window), f::InfrastructureSystems.Scenarios, initial_time) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/scenarios.jl:211

Ambiguity #3
(::InfrastructureSystems.var"#get_window##kw")(::Any, ::typeof(InfrastructureSystems.get_window), f::InfrastructureSystems.Deterministic, initial_time) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/deterministic.jl:258
(::InfrastructureSystems.var"#get_window##kw")(::Any, ::typeof(InfrastructureSystems.get_window), forecast::InfrastructureSystems.Forecast, index::Int64) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/forecasts.jl:64

Ambiguity #4
get_window(forecast::InfrastructureSystems.Forecast, index::Int64; len) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/forecasts.jl:64
get_window(f::InfrastructureSystems.Scenarios, initial_time; len) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/scenarios.jl:211

Ambiguity #5
get_window(forecast::InfrastructureSystems.Forecast, index::Int64; len) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/forecasts.jl:64
get_window(f::InfrastructureSystems.Probabilistic, initial_time; len) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/probabilistic.jl:259

Ambiguity #6
(::InfrastructureSystems.var"#get_window##kw")(::Any, ::typeof(InfrastructureSystems.get_window), forecast::InfrastructureSystems.Forecast, index::Int64) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/forecasts.jl:64
(::InfrastructureSystems.var"#get_window##kw")(::Any, ::typeof(InfrastructureSystems.get_window), f::InfrastructureSystems.Probabilistic, initial_time) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/probabilistic.jl:259

Ambiguity #7
get_window(f::InfrastructureSystems.Deterministic, initial_time; len) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/deterministic.jl:258
get_window(forecast::InfrastructureSystems.Forecast, index::Int64; len) in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/forecasts.jl:64

Ambiguity #8
check_limits(::Type{T}, valid_info::InfrastructureSystems.ValidationInfo, field_value) where T<:Union{Nothing, Real} in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/validation.jl:175
check_limits(::Type{T}, valid_info::InfrastructureSystems.ValidationInfo, field_value) where T<:Union{Nothing, NamedTuple} in InfrastructureSystems at /Users/jdlara/.julia/dev/InfrastructureSystems/src/validation.jl:184