Closed raphaelsaavedra closed 3 years ago
Implicated line is https://github.com/NREL-SIIP/InfrastructureSystems.jl/blob/ce8f4eefadb9417fc4ed44a6808e27b7297b4409/src/utils/logging.jl#L20
Base.find_package("InfrastructureSystems")
can return nothing
maybe we want pathof(InfrastructureSystems)
here?
@nickrobinson251 Yes, sorry for the trouble.
@jd-lara We need to adjust the CI/cross-package testing to import packages the way users do it.
We need to adjust the CI/cross-package testing to import packages the way users do it.
Shall we open an issue for this?
I wonder what is different... maybe we need to add
rather than develop
? (but that's a wild guess)
https://github.com/NREL-SIIP/InfrastructureSystems.jl/blob/d15c322cd662e12cb13923d640b5cf9b40629de1/.github/workflows/cross-package-test.yml#L37
We need to adjust the CI/cross-package testing to import packages the way users do it.
Shall we open an issue for this?
I wonder what is different... maybe we need to
add
rather thandevelop
? (but that's a wild guess)
I wonder why the current set up didn't pick it up. This issue also didn't came out in the PSY stand alone tests
I'm not super familiar with this workflow, but isn't it because you're only running checks for packages that directly depend on IS? I think this error would only occur in a package that has an indirect dependency e.g. having PSY as dep but not IS
To do that I think we need to make a dummy module with an IS dependency and some test workflow. We tried that at some point to test the @forward macro but it was a huge hassle that never really worked well.
Stacktrace: