NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
38 stars 20 forks source link

Fix the has_forecasts column in show_components_table #256

Closed daniel-thom closed 2 years ago

daniel-thom commented 2 years ago

The column was left as undefined. Introduced in v1.12. This shouldn't need a new release because PSY overrides this method. However, that could be a problem if the prior version of PSY was allowed to use v1.12. Is that the case @jd-lara ? I thought I had noted them as incompatible.

codecov[bot] commented 2 years ago

Codecov Report

Merging #256 (15dbaf2) into master (3222f2b) will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   77.01%   77.19%   +0.18%     
==========================================
  Files          43       43              
  Lines        3441     3307     -134     
==========================================
- Hits         2650     2553      -97     
+ Misses        791      754      -37     
Flag Coverage Δ
unittests 77.19% <100.00%> (+0.18%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/print.jl 51.08% <100.00%> (+0.56%) :arrow_up:
src/utils/utils.jl 64.28% <0.00%> (-1.60%) :arrow_down:
src/utils/generate_structs.jl 84.40% <0.00%> (-0.95%) :arrow_down:
src/internal.jl 78.00% <0.00%> (-0.85%) :arrow_down:
src/probabilistic.jl 77.19% <0.00%> (-0.78%) :arrow_down:
src/scenarios.jl 83.67% <0.00%> (-0.65%) :arrow_down:
src/utils/recorder_events.jl 91.11% <0.00%> (-0.56%) :arrow_down:
src/deterministic.jl 81.53% <0.00%> (-0.56%) :arrow_down:
src/deterministic_single_time_series.jl 75.86% <0.00%> (-0.41%) :arrow_down:
... and 18 more