NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
38 stars 20 forks source link

Update to latest pretty_table interface #259

Closed daniel-thom closed 2 years ago

daniel-thom commented 2 years ago

The previous code was using a deprecated call.

jd-lara commented 2 years ago

@daniel-thom can you add a compat entry to the project.toml file please?

PrettyTables = "1.2"
daniel-thom commented 2 years ago

@daniel-thom can you add a compat entry to the project.toml file please?

PrettyTables = "1.2"

That should not be required. v1.2.0 removed the depecrated methods. The newer methods were already present. I can still do it if you want.

jd-lara commented 2 years ago

@daniel-thom can you add a compat entry to the project.toml file please?

PrettyTables = "1.2"

That should not be required. v1.2.0 removed the depecrated methods. The newer methods were already present. I can still do it if you want.

This is for future-proofing since this will allow users to use IS with versions earlier than 1.2 after they remove the deperecation.

we could do

 PrettyTables = "~1.2"
daniel-thom commented 2 years ago

@daniel-thom can you add a compat entry to the project.toml file please?

PrettyTables = "1.2"

That should not be required. v1.2.0 removed the depecrated methods. The newer methods were already present. I can still do it if you want.

This is for future-proofing since this will allow users to use IS with versions earlier than 1.2 after they remove the deperecation.

we could do

PrettyTables = "~1.2"

They can't remove the deprecated code until they make a breaking release in 2.0.0. I'll make the change to remove the need for continued discussion.

codecov[bot] commented 2 years ago

Codecov Report

Merging #259 (87083f2) into master (0e264aa) will decrease coverage by 0.70%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   78.24%   77.54%   -0.71%     
==========================================
  Files          43       43              
  Lines        3508     3304     -204     
==========================================
- Hits         2745     2562     -183     
+ Misses        763      742      -21     
Flag Coverage Δ
unittests 77.54% <100.00%> (-0.71%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/print.jl 51.08% <100.00%> (-1.68%) :arrow_down:
src/utils/recorder_events.jl 91.11% <100.00%> (-0.65%) :arrow_down:
src/time_series_utils.jl 70.00% <0.00%> (-5.00%) :arrow_down:
src/InfrastructureSystems.jl 80.00% <0.00%> (-3.34%) :arrow_down:
src/utils/utils.jl 64.28% <0.00%> (-1.87%) :arrow_down:
src/time_series_storage.jl 77.77% <0.00%> (-1.54%) :arrow_down:
src/utils/generate_structs.jl 84.40% <0.00%> (-1.07%) :arrow_down:
src/time_series_formats.jl 72.04% <0.00%> (-1.04%) :arrow_down:
src/internal.jl 78.00% <0.00%> (-0.85%) :arrow_down:
... and 24 more