Closed jd-lara closed 2 years ago
Merging #260 (2c73175) into master (87083f2) will increase coverage by
0.21%
. The diff coverage is84.12%
.:exclamation: Current head 2c73175 differs from pull request most recent head e40e127. Consider uploading reports for the commit e40e127 to get more accurate results
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 77.54% 77.75% +0.21%
==========================================
Files 43 43
Lines 3304 3340 +36
==========================================
+ Hits 2562 2597 +35
- Misses 742 743 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 77.75% <84.12%> (+0.21%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/deterministic_single_time_series.jl | 75.86% <0.00%> (ø) |
|
src/utils/utils.jl | 64.28% <0.00%> (ø) |
|
src/component.jl | 93.51% <50.00%> (+0.02%) |
:arrow_up: |
src/internal.jl | 78.84% <50.00%> (+0.84%) |
:arrow_up: |
src/validation.jl | 12.12% <50.00%> (ø) |
|
src/utils/print.jl | 51.59% <60.00%> (+0.50%) |
:arrow_up: |
src/utils/recorder_events.jl | 91.30% <75.00%> (+0.19%) |
:arrow_up: |
src/utils/logging.jl | 91.90% <83.33%> (+0.04%) |
:arrow_up: |
src/hdf5_time_series_storage.jl | 93.68% <100.00%> (+0.13%) |
:arrow_up: |
src/in_memory_time_series_storage.jl | 73.33% <100.00%> (+0.22%) |
:arrow_up: |
... and 10 more |
The cases where the formatter "fixed" leaky returns makes the code less clear. Shall I go back through this code and add explicit returns?
@daniel-thom this should prevent dealing with formatter versions in your local environment. I also added new flags.