codecov[bot]
commented
2 years ago Codecov Report
Merging #265 (fbd61a1) into master (becfe90) will decrease coverage by
0.71%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 78.49% 77.78% -0.72%
==========================================
Files 43 43
Lines 3557 3353 -204
==========================================
- Hits 2792 2608 -184
+ Misses 765 745 -20 | Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.78% <100.00%> (-0.72%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/utils/logging.jl | 91.39% <100.00%> (-0.57%) |
:arrow_down: |
| src/time_series_utils.jl | 70.00% <0.00%> (-5.00%) |
:arrow_down: |
| src/InfrastructureSystems.jl | 80.00% <0.00%> (-3.34%) |
:arrow_down: |
| src/utils/utils.jl | 64.28% <0.00%> (-1.87%) |
:arrow_down: |
| src/utils/print.jl | 51.59% <0.00%> (-1.61%) |
:arrow_down: |
| src/time_series_storage.jl | 77.77% <0.00%> (-1.54%) |
:arrow_down: |
| src/utils/generate_structs.jl | 84.54% <0.00%> (-1.05%) |
:arrow_down: |
| src/time_series_formats.jl | 72.04% <0.00%> (-1.04%) |
:arrow_down: |
| src/internal.jl | 78.84% <0.00%> (-0.79%) |
:arrow_down: |
| src/probabilistic.jl | 77.19% <0.00%> (-0.78%) |
:arrow_down: |
| ... and 23 more |
The TerminalLogger causes unexpected results when variables contain underscores. I think we're better off with just the ConsoleLogger. Progress logging is unaffected. Another option is to make TerminalLogger a kwarg, but I'm guessing that no one will ever use it. This is just a proposal; feel free to decline it.