NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
38 stars 20 forks source link

Fail transform_single_time_series! on conflicting inputs #267

Closed daniel-thom closed 2 years ago

daniel-thom commented 2 years ago

This handles a case found by @claytonpbarrows where we created an invalid DeterministicSingleTimeSeries. It happened when the first SingleTimeSeries had a length one greater than the second.

codecov[bot] commented 2 years ago

Codecov Report

Merging #267 (bccfe78) into master (c7439c6) will decrease coverage by 0.66%. The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   78.50%   77.83%   -0.67%     
==========================================
  Files          43       43              
  Lines        3559     3366     -193     
==========================================
- Hits         2794     2620     -174     
+ Misses        765      746      -19     
Flag Coverage Δ
unittests 77.83% <92.30%> (-0.67%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/system_data.jl 88.23% <88.88%> (-0.19%) :arrow_down:
src/component.jl 93.60% <100.00%> (-0.26%) :arrow_down:
src/time_series_utils.jl 70.00% <0.00%> (-5.00%) :arrow_down:
src/InfrastructureSystems.jl 80.00% <0.00%> (-3.34%) :arrow_down:
src/utils/utils.jl 64.28% <0.00%> (-1.87%) :arrow_down:
src/utils/print.jl 51.59% <0.00%> (-1.61%) :arrow_down:
src/time_series_storage.jl 77.77% <0.00%> (-1.54%) :arrow_down:
src/utils/generate_structs.jl 84.54% <0.00%> (-1.05%) :arrow_down:
src/time_series_formats.jl 72.04% <0.00%> (-1.04%) :arrow_down:
src/internal.jl 78.84% <0.00%> (-0.79%) :arrow_down:
... and 24 more