search

NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
39 stars 21 forks source link

Jd/add infos #316

Closed jd-lara closed 9 months ago

jd-lara commented 9 months ago

@daniel-thom I addressed most of the comments. There are a few failing tests related to the time series and the serialization

jd-lara commented 9 months ago

Tests are expected to fail on serialization/deserialization

codecov[bot] commented 9 months ago

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (43d40cc) 78.08% compared to head (deebdbc) 78.35%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316/graphs/tree.svg?width=650&height=150&src=pr&token=I73yjxYxgn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #316 +/- ## ========================================== + Coverage 78.08% 78.35% +0.27% ========================================== Files 44 49 +5 Lines 3737 3964 +227 ========================================== + Hits 2918 3106 +188 - Misses 819 858 +39 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `78.35% <83.13%> (+0.27%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/components.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvbXBvbmVudHMuamw=) | `90.78% <100.00%> (-1.68%)` | :arrow_down: | | [src/containers.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvbnRhaW5lcnMuamw=) | `100.00% <100.00%> (ø)` | | | [src/deterministic.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldGVybWluaXN0aWMuamw=) | `82.08% <100.00%> (-0.27%)` | :arrow_down: | | [src/deterministic\_single\_time\_series.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldGVybWluaXN0aWNfc2luZ2xlX3RpbWVfc2VyaWVzLmps) | `76.27% <ø> (ø)` | | | [src/hdf5\_time\_series\_storage.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2hkZjVfdGltZV9zZXJpZXNfc3RvcmFnZS5qbA==) | `91.10% <100.00%> (ø)` | | | [src/in\_memory\_time\_series\_storage.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2luX21lbW9yeV90aW1lX3Nlcmllc19zdG9yYWdlLmps) | `73.22% <100.00%> (ø)` | | | [src/internal.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2ludGVybmFsLmps) | `80.70% <100.00%> (+1.75%)` | :arrow_up: | | [src/scenarios.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NjZW5hcmlvcy5qbA==) | `84.31% <100.00%> (ø)` | | | [src/time\_series\_cache.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX2NhY2hlLmps) | `92.56% <100.00%> (ø)` | | | [src/time\_series\_container.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX2NvbnRhaW5lci5qbA==) | `76.78% <ø> (ø)` | | | ... and [24 more](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/316?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | |