search

NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
39 stars 21 forks source link

add keys code #335

Closed jd-lara closed 5 months ago

jd-lara commented 7 months ago

Preliminary work to move some of the optimization object from PowerSimulations to IS.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 30.76923% with 405 lines in your changes are missing coverage. Please review.

Project coverage is 74.37%. Comparing base (d0533aa) to head (60d069f). Report is 20 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335/graphs/tree.svg?width=650&height=150&src=pr&token=I73yjxYxgn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #335 +/- ## ========================================== - Coverage 79.77% 74.37% -5.41% ========================================== Files 54 64 +10 Lines 4341 4952 +611 ========================================== + Hits 3463 3683 +220 - Misses 878 1269 +391 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `74.37% <30.76%> (-5.41%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/InfrastructureSystems.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2FInfrastructureSystems.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL0luZnJhc3RydWN0dXJlU3lzdGVtcy5qbA==) | `80.00% <ø> (ø)` | | | [src/Optimization/Optimization.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2FOptimization%2FOptimization.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL09wdGltaXphdGlvbi9PcHRpbWl6YXRpb24uamw=) | `100.00% <100.00%> (ø)` | | | [src/Optimization/optimization\_container\_types.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2FOptimization%2Foptimization_container_types.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL09wdGltaXphdGlvbi9vcHRpbWl6YXRpb25fY29udGFpbmVyX3R5cGVzLmps) | `100.00% <100.00%> (ø)` | | | [src/Optimization/optimizer\_stats.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2FOptimization%2Foptimizer_stats.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL09wdGltaXphdGlvbi9vcHRpbWl6ZXJfc3RhdHMuamw=) | `100.00% <100.00%> (ø)` | | | [src/hdf5\_time\_series\_storage.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2Fhdf5_time_series_storage.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2hkZjVfdGltZV9zZXJpZXNfc3RvcmFnZS5qbA==) | `92.03% <ø> (+0.71%)` | :arrow_up: | | [src/internal.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2Finternal.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2ludGVybmFsLmps) | `80.70% <100.00%> (ø)` | | | [src/single\_time\_series.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2Fsingle_time_series.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NpbmdsZV90aW1lX3Nlcmllcy5qbA==) | `68.00% <ø> (+0.98%)` | :arrow_up: | | [src/system\_data.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2Fsystem_data.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3N5c3RlbV9kYXRhLmps) | `91.11% <100.00%> (+0.14%)` | :arrow_up: | | [src/utils/recorder\_events.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2Futils%2Frecorder_events.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3V0aWxzL3JlY29yZGVyX2V2ZW50cy5qbA==) | `92.23% <100.00%> (ø)` | | | [...rc/Optimization/optimization\_container\_metadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree&filepath=src%2FOptimization%2Foptimization_container_metadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL09wdGltaXphdGlvbi9vcHRpbWl6YXRpb25fY29udGFpbmVyX21ldGFkYXRhLmps) | `95.23% <95.23%> (ø)` | | | ... and [13 more](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/335/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)
jd-lara commented 7 months ago

Much of the following PSI files seem to fit the same category of what you moved here:

  • src/operation/operation_model_interface.jl
  • src/core/operation_model_abstract_types.jl (ProblemResults)
  • src/operation/time_series_interface.jl

notes

  1. From the file operation_model_interface.jl we should move the methods that call get_internal(model)
  2. Move TimeSeriesKey (?)
jd-lara commented 7 months ago

This PR is ready merge as soon as https://github.com/NREL-Sienna/PowerSimulations.jl/pull/1068 is working and tests are included.

jd-lara commented 6 months ago

This PR is ready merge as soon as NREL-Sienna/PowerSimulations.jl#1068 is working and tests are included.

@daniel-thom the PR on PSI is working and the only tests missing are for there results/results_exports. I think we should merge and write the test on a separate PR.