search

NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
35 stars 20 forks source link

Share time series data on a component across multiple fields #343

Closed daniel-thom closed 3 months ago

daniel-thom commented 3 months ago

This PR adds new time series data constructors that enable time series instances with different names to share the same data. The targeted use case is one where a generator wants to use the same time series data for the fields active_power and reactive_power.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.92%. Comparing base (44eae02) to head (00decc9).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343/graphs/tree.svg?width=650&height=150&src=pr&token=I73yjxYxgn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #343 +/- ## ========================================== - Coverage 80.39% 79.92% -0.47% ========================================== Files 54 54 Lines 4386 4398 +12 ========================================== - Hits 3526 3515 -11 - Misses 860 883 +23 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `79.92% <93.54%> (-0.47%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/deterministic.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldGVybWluaXN0aWMuamw=) | `69.11% <100.00%> (-15.50%)` | :arrow_down: | | [src/probabilistic.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3Byb2JhYmlsaXN0aWMuamw=) | `81.66% <100.00%> (+0.96%)` | :arrow_up: | | [src/scenarios.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NjZW5hcmlvcy5qbA==) | `85.18% <100.00%> (+0.87%)` | :arrow_up: | | [src/single\_time\_series.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NpbmdsZV90aW1lX3Nlcmllcy5qbA==) | `68.00% <100.00%> (+0.98%)` | :arrow_up: | | [src/time\_series\_formats.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX2Zvcm1hdHMuamw=) | `73.07% <100.00%> (ø)` | | | [src/utils/test.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3V0aWxzL3Rlc3Quamw=) | `84.21% <100.00%> (+0.42%)` | :arrow_up: | | [src/in\_memory\_time\_series\_storage.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2luX21lbW9yeV90aW1lX3Nlcmllc19zdG9yYWdlLmps) | `73.64% <93.33%> (ø)` | | | [src/time\_series\_parser.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX3BhcnNlci5qbA==) | `71.08% <0.00%> (+0.84%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/343/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)
jd-lara commented 3 months ago

@GabrielKS we might need to make cases in PSB that include this.