IS Remaining TODOs for Second Cost Refactor - Githubissues

NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure

https://nrel-sienna.github.io/InfrastructureSystems.jl/

BSD 3-Clause "New" or "Revised" License

35 stars 20 forks source link

IS Remaining TODOs for Second Cost Refactor #352

Open GabrielKS opened 2 months ago

GabrielKS commented 2 months ago

This is a list of TODOs that remain unfinished from https://github.com/NREL-Sienna/InfrastructureSystems.jl/pull/344, they should all be addressed before IS is released.

[x] #359
[ ] In retransform_hdf_array, use of map rather than preallocation might be a performance issue (see https://github.com/NREL-Sienna/InfrastructureSystems.jl/blob/aabe96765b0944077cdf215e2e263f3d2fe8db15/src/hdf5_time_series_storage.jl#L708 etc.).
[x] Possible further type stability issues in transform_array_for_hdf, see review comment https://github.com/NREL-Sienna/InfrastructureSystems.jl/pull/344/files/241514d1b15282f1259f9a780b2c62a8fb4c6238#r1567689474
[ ] Fix convert_data as per https://github.com/NREL-Sienna/InfrastructureSystems.jl/pull/344#discussion_r1578413289

These seem to all be potential performance issues.