NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
35 stars 20 forks source link

Refactor storage of supplemental attributes and time series #357

Closed daniel-thom closed 2 months ago

daniel-thom commented 2 months ago

closes #360

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 93.58025% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 76.65%. Comparing base (6563b7b) to head (de90745).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357/graphs/tree.svg?width=650&height=150&src=pr&token=I73yjxYxgn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #357 +/- ## ========================================== + Coverage 75.82% 76.65% +0.82% ========================================== Files 68 66 -2 Lines 4894 5003 +109 ========================================== + Hits 3711 3835 +124 + Misses 1183 1168 -15 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `76.65% <93.58%> (+0.82%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/InfrastructureSystems.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2FInfrastructureSystems.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL0luZnJhc3RydWN0dXJlU3lzdGVtcy5qbA==) | `90.00% <100.00%> (+10.00%)` | :arrow_up: | | [src/containers.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Fcontainers.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvbnRhaW5lcnMuamw=) | `100.00% <ø> (ø)` | | | [src/geographic\_supplemental\_attribute.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Fgeographic_supplemental_attribute.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlb2dyYXBoaWNfc3VwcGxlbWVudGFsX2F0dHJpYnV0ZS5qbA==) | `83.33% <100.00%> (-4.17%)` | :arrow_down: | | [src/serialization.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Fserialization.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NlcmlhbGl6YXRpb24uamw=) | `72.72% <ø> (-1.66%)` | :arrow_down: | | [src/system\_data.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Fsystem_data.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3N5c3RlbV9kYXRhLmps) | `90.18% <100.00%> (-0.49%)` | :arrow_down: | | [src/time\_series\_manager.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Ftime_series_manager.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX21hbmFnZXIuamw=) | `92.30% <100.00%> (-0.80%)` | :arrow_down: | | [src/time\_series\_metadata\_store.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Ftime_series_metadata_store.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX21ldGFkYXRhX3N0b3JlLmps) | `97.25% <100.00%> (+0.60%)` | :arrow_up: | | [src/utils/logging.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Futils%2Flogging.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3V0aWxzL2xvZ2dpbmcuamw=) | `91.50% <ø> (ø)` | | | [src/utils/utils.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Futils%2Futils.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3V0aWxzL3V0aWxzLmps) | `58.57% <ø> (+0.06%)` | :arrow_up: | | [src/component.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree&filepath=src%2Fcomponent.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvbXBvbmVudC5qbA==) | `96.84% <97.67%> (+5.17%)` | :arrow_up: | | ... and [8 more](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/357/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)
jd-lara commented 2 months ago

The only minor concern I have is the use of list_ in some cases but mostly that's for interfaces that users won't be exposed to.