NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
35 stars 20 forks source link

Redefine TimeSeriesKey #365

Closed daniel-thom closed 1 month ago

daniel-thom commented 1 month ago

Change the TimeSeriesInfo structs to be keys and return them from add_time_series!(). Remove the old TimeSeriesKey.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.83%. Comparing base (c1f84fc) to head (4dbe394).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365/graphs/tree.svg?width=650&height=150&src=pr&token=I73yjxYxgn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #365 +/- ## ========================================== + Coverage 76.53% 76.83% +0.29% ========================================== Files 66 66 Lines 5012 5016 +4 ========================================== + Hits 3836 3854 +18 + Misses 1176 1162 -14 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `76.83% <100.00%> (+0.29%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/internal.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&filepath=src%2Finternal.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2ludGVybmFsLmps) | `84.37% <100.00%> (-1.11%)` | :arrow_down: | | [src/serialization.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&filepath=src%2Fserialization.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NlcmlhbGl6YXRpb24uamw=) | `72.72% <100.00%> (ø)` | | | [src/system\_data.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&filepath=src%2Fsystem_data.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3N5c3RlbV9kYXRhLmps) | `90.27% <100.00%> (+0.05%)` | :arrow_up: | | [src/time\_series\_interface.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&filepath=src%2Ftime_series_interface.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX2ludGVyZmFjZS5qbA==) | `95.50% <100.00%> (ø)` | | | [src/time\_series\_manager.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&filepath=src%2Ftime_series_manager.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX21hbmFnZXIuamw=) | `91.26% <100.00%> (ø)` | | | [src/time\_series\_metadata\_store.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&filepath=src%2Ftime_series_metadata_store.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX21ldGFkYXRhX3N0b3JlLmps) | `96.98% <100.00%> (ø)` | | | [src/time\_series\_structs.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&filepath=src%2Ftime_series_structs.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX3N0cnVjdHMuamw=) | `100.00% <100.00%> (+60.00%)` | :arrow_up: | | [src/utils/print.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/365?src=pr&el=tree&filepath=src%2Futils%2Fprint.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3V0aWxzL3ByaW50Lmps) | `69.29% <100.00%> (+0.25%)` | :arrow_up: |