Store forecast horizon as Dates.Period instead of Int

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 96.52174% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.17%. Comparing base (d96bb9f) to head (6a6cdef). Report is 6 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #368 +/- ## ========================================== + Coverage 76.86% 77.17% +0.31% ========================================== Files 66 66 Lines 5018 5065 +47 ========================================== + Hits 3857 3909 +52 + Misses 1161 1156 -5 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `77.17% <96.52%> (+0.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/abstract\_time\_series.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fabstract_time_series.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2Fic3RyYWN0X3RpbWVfc2VyaWVzLmps) | `88.88% <100.00%> (+3.17%)` | :arrow_up: | | [src/component.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fcomponent.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvbXBvbmVudC5qbA==) | `98.33% <ø> (+1.49%)` | :arrow_up: | | [src/deterministic.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fdeterministic.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldGVybWluaXN0aWMuamw=) | `67.64% <100.00%> (ø)` | | | [src/deterministic\_single\_time\_series.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fdeterministic_single_time_series.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldGVybWluaXN0aWNfc2luZ2xlX3RpbWVfc2VyaWVzLmps) | `78.68% <100.00%> (+2.41%)` | :arrow_up: | | [src/generated/DeterministicMetadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fgenerated%2FDeterministicMetadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlbmVyYXRlZC9EZXRlcm1pbmlzdGljTWV0YWRhdGEuamw=) | `62.96% <ø> (ø)` | | | [src/generated/ProbabilisticMetadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fgenerated%2FProbabilisticMetadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlbmVyYXRlZC9Qcm9iYWJpbGlzdGljTWV0YWRhdGEuamw=) | `55.55% <ø> (ø)` | | | [src/generated/ScenariosMetadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fgenerated%2FScenariosMetadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlbmVyYXRlZC9TY2VuYXJpb3NNZXRhZGF0YS5qbA==) | `55.55% <ø> (ø)` | | | [src/generated/SingleTimeSeriesMetadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fgenerated%2FSingleTimeSeriesMetadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlbmVyYXRlZC9TaW5nbGVUaW1lU2VyaWVzTWV0YWRhdGEuamw=) | `71.42% <ø> (+3.24%)` | :arrow_up: | | [src/probabilistic.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fprobabilistic.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3Byb2JhYmlsaXN0aWMuamw=) | `81.35% <100.00%> (-0.32%)` | :arrow_down: | | [src/scenarios.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree&filepath=src%2Fscenarios.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NjZW5hcmlvcy5qbA==) | `84.90% <100.00%> (-0.28%)` | :arrow_down: | | ... and [9 more](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/368/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)

[daniel-thom]

@jd-lara I thought this was obvious, but it should not have been merged until PSY has a matching branch. I haven't been able to test that because of https://github.com/NREL-Sienna/PowerSystemCaseBuilder.jl/issues/88

[jd-lara]

@jd-lara I thought this was obvious, but it should not have been merged until PSY has a matching branch. I haven't been able to test that because of NREL-Sienna/PowerSystemCaseBuilder.jl#88

Fixed here https://github.com/NREL-Sienna/PowerSystemCaseBuilder.jl/pull/89