search

NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
35 stars 20 forks source link

Regenerate structs to pass tests #376

Closed GabrielKS closed 3 weeks ago

GabrielKS commented 3 weeks ago

https://github.com/NREL-Sienna/InfrastructureSystems.jl/pull/374 changed the template format, causing these sorts of errors:

┌ Error: Generated structs do not match descriptor file
│   file1 = "DeterministicMetadata.jl"
│   line1 = "- `resolution::Dates.Period`:"
│   line2 = "- `resolution::Dates.Period`"
└ @ .../InfrastructureSystems.jl/src/utils/generate_structs.jl:268

This just regenerates the structs to fix the errors. I do note that the format implied by https://github.com/NREL-Sienna/InfrastructureSystems.jl/pull/374 is a little strange for fields without descriptions, like resolution; maybe that should be changed?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.16%. Comparing base (beb1cf0) to head (1a2918c). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376/graphs/tree.svg?width=650&height=150&src=pr&token=I73yjxYxgn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #376 +/- ## ======================================= Coverage 77.15% 77.16% ======================================= Files 66 66 Lines 5070 5072 +2 ======================================= + Hits 3912 3914 +2 Misses 1158 1158 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `77.16% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/generated/DeterministicMetadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376?src=pr&el=tree&filepath=src%2Fgenerated%2FDeterministicMetadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlbmVyYXRlZC9EZXRlcm1pbmlzdGljTWV0YWRhdGEuamw=) | `62.96% <ø> (ø)` | | | [src/generated/ProbabilisticMetadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376?src=pr&el=tree&filepath=src%2Fgenerated%2FProbabilisticMetadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlbmVyYXRlZC9Qcm9iYWJpbGlzdGljTWV0YWRhdGEuamw=) | `55.55% <ø> (ø)` | | | [src/generated/ScenariosMetadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376?src=pr&el=tree&filepath=src%2Fgenerated%2FScenariosMetadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlbmVyYXRlZC9TY2VuYXJpb3NNZXRhZGF0YS5qbA==) | `55.55% <ø> (ø)` | | | [src/generated/SingleTimeSeriesMetadata.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/376?src=pr&el=tree&filepath=src%2Fgenerated%2FSingleTimeSeriesMetadata.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2dlbmVyYXRlZC9TaW5nbGVUaW1lU2VyaWVzTWV0YWRhdGEuamw=) | `71.42% <ø> (ø)` | |
GabrielKS commented 3 weeks ago

Closing as I didn't notice this had already been done in https://github.com/NREL-Sienna/InfrastructureSystems.jl/pull/375