NREL-Sienna / InfrastructureSystems.jl

Utility package for Sienna's simulation infrastructure
https://nrel-sienna.github.io/InfrastructureSystems.jl/
BSD 3-Clause "New" or "Revised" License
35 stars 20 forks source link

Revert change to time series data checks #383

Closed daniel-thom closed 1 week ago

daniel-thom commented 1 week ago

This was a regression in #381 that broke PowerSimulations.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.70%. Comparing base (d7e6629) to head (f891c36).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383/graphs/tree.svg?width=650&height=150&src=pr&token=I73yjxYxgn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #383 +/- ## ========================================== - Coverage 77.73% 77.70% -0.04% ========================================== Files 68 68 Lines 5295 5287 -8 ========================================== - Hits 4116 4108 -8 Misses 1179 1179 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `77.70% <100.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/abstract\_time\_series.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&filepath=src%2Fabstract_time_series.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2Fic3RyYWN0X3RpbWVfc2VyaWVzLmps) | `93.75% <ø> (ø)` | | | [src/deterministic.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&filepath=src%2Fdeterministic.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldGVybWluaXN0aWMuamw=) | `67.64% <ø> (-1.37%)` | :arrow_down: | | [src/forecasts.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&filepath=src%2Fforecasts.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2ZvcmVjYXN0cy5qbA==) | `86.56% <100.00%> (ø)` | | | [src/probabilistic.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&filepath=src%2Fprobabilistic.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3Byb2JhYmlsaXN0aWMuamw=) | `81.35% <ø> (-0.91%)` | :arrow_down: | | [src/scenarios.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&filepath=src%2Fscenarios.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NjZW5hcmlvcy5qbA==) | `84.90% <ø> (-0.81%)` | :arrow_down: | | [src/single\_time\_series.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&filepath=src%2Fsingle_time_series.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3NpbmdsZV90aW1lX3Nlcmllcy5qbA==) | `70.64% <100.00%> (ø)` | | | [src/time\_series\_cache.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&filepath=src%2Ftime_series_cache.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX2NhY2hlLmps) | `90.96% <100.00%> (ø)` | | | [src/time\_series\_manager.jl](https://app.codecov.io/gh/NREL-Sienna/InfrastructureSystems.jl/pull/383?src=pr&el=tree&filepath=src%2Ftime_series_manager.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3RpbWVfc2VyaWVzX21hbmFnZXIuamw=) | `95.86% <100.00%> (+0.03%)` | :arrow_up: |