search

NREL-Sienna / PowerFlows.jl

Collection of Power Flow solution methods based on PowerSystems.jl
https://nrel-sienna.github.io/PowerFlows.jl/stable/
BSD 3-Clause "New" or "Revised" License
16 stars 9 forks source link

Better specify `PowerFlowData` parametric type aliases #50

Open GabrielKS opened 1 week ago

GabrielKS commented 1 week ago

This:

Screenshot 2024-10-16 at 11 40 16 PM

is

GabrielKS commented 1 week ago

I'm not fully convinced that these pseudo-subtypes should be based on the types of the matrices they contain; that feels like an implementation detail, even though it's a pretty fundamental one. One can at least in principle imagine a pair of PowerFlowDatas with the same types of matrices except you want to solve them differently. Maybe the PowerFlowData contains the PowerFlowEvaluationModel it was constructed with, is parameterized on that, and that's what the aliases key onto (or at that point it's readable enough that we don't need the aliases)? Or maybe one is required to pass a PowerFlowEvaluationModel to solve_powerflow! along with the PowerFlowData? Guess this overlaps with https://github.com/NREL-Sienna/PowerFlows.jl/issues/38.