search

NREL-Sienna / PowerNetworkMatrices.jl

Methods to generate matrix representations of power systems matrices
BSD 3-Clause "New" or "Revised" License
20 stars 8 forks source link

fix ptdf constructor #66

Closed jd-lara closed 9 months ago

jd-lara commented 9 months ago

closes #61 also

github-actions[bot] commented 9 months ago
Performance Results Version Precompile Time
Main 1.915014113
This Branch 1.884843827
Version Execute Time
Main-Build PTDF First 3.846612695
Main-Build PTDF Second 0.125544163
Main-Build Ybus First 0.334052698
Main-Build Ybus Second 0.007551007
Main-Build LODF First 0.748439114
Main-Build LODF Second 0.194094971
This Branch-Build PTDF First 3.772506783
This Branch-Build PTDF Second 0.125749847
This Branch-Build Ybus First 0.339918822
This Branch-Build Ybus Second 0.007620996
This Branch-Build LODF First 0.753213244
This Branch-Build LODF Second 0.189575795
codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4371745) 76.42% compared to head (c822b99) 76.38%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/66/graphs/tree.svg?width=650&height=150&src=pr&token=2VvekKsf11&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== - Coverage 76.42% 76.38% -0.05% ========================================== Files 15 15 Lines 1281 1283 +2 ========================================== + Hits 979 980 +1 - Misses 302 303 +1 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/66/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/66/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `76.38% <60.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/common.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvbW1vbi5qbA==) | `92.51% <50.00%> (-0.59%)` | :arrow_down: | | [src/ptdf\_calculations.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3B0ZGZfY2FsY3VsYXRpb25zLmps) | `89.61% <66.66%> (+0.05%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/66/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)
jd-lara commented 9 months ago

closed, these changes are included in #67