NREL-Sienna / PowerNetworkMatrices.jl

Methods to generate matrix representations of power systems matrices
BSD 3-Clause "New" or "Revised" License
20 stars 8 forks source link

afc/radial_branches_matrices #67

Closed alefcastelli closed 8 months ago

alefcastelli commented 9 months ago

The PR adds new features regarding the possibility to evaluate all the network matrices considering a simplified system without leaf buses and radial branches.

The option reduce_radial_branches is available for all matrix types.

github-actions[bot] commented 9 months ago
Performance Results Version Precompile Time
Main 1.061942991
This Branch 1.050490793
Version Execute Time
Main-Build PTDF First 5.140552071
Main-Build PTDF Second 0.080847141
Main-Build Ybus First 0.365427704
Main-Build Ybus Second 0.007624685
Main-Build LODF First 1.00409551
Main-Build LODF Second 0.17395954
This Branch-Build PTDF First 5.068937842
This Branch-Build PTDF Second 0.109859449
This Branch-Build Ybus First 0.360871366
This Branch-Build Ybus Second 0.006972285
This Branch-Build LODF First 1.019933353
This Branch-Build LODF Second 0.296530531
codecov[bot] commented 9 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4a055d1) 76.40% compared to head (f590cb1) 78.13%. Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67/graphs/tree.svg?width=650&height=150&src=pr&token=2VvekKsf11&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #67 +/- ## ========================================== + Coverage 76.40% 78.13% +1.73% ========================================== Files 15 15 Lines 1280 1386 +106 ========================================== + Hits 978 1083 +105 - Misses 302 303 +1 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `78.13% <91.44%> (+1.73%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/BA\_ABA\_matrices.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL0JBX0FCQV9tYXRyaWNlcy5qbA==) | `98.07% <100.00%> (+0.25%)` | :arrow_up: | | [src/PowerNetworkMatrices.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL1Bvd2VyTmV0d29ya01hdHJpY2VzLmps) | `100.00% <ø> (ø)` | | | [src/incedence\_matrix.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2luY2VkZW5jZV9tYXRyaXguamw=) | `85.00% <100.00%> (+8.07%)` | :arrow_up: | | [src/system\_utils.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3N5c3RlbV91dGlscy5qbA==) | `100.00% <100.00%> (ø)` | | | [src/virtual\_lodf\_calculations.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3ZpcnR1YWxfbG9kZl9jYWxjdWxhdGlvbnMuamw=) | `89.88% <100.00%> (+2.10%)` | :arrow_up: | | [src/virtual\_ptdf\_calculations.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3ZpcnR1YWxfcHRkZl9jYWxjdWxhdGlvbnMuamw=) | `88.76% <100.00%> (+2.24%)` | :arrow_up: | | [src/ptdf\_calculations.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3B0ZGZfY2FsY3VsYXRpb25zLmps) | `93.06% <97.29%> (+3.50%)` | :arrow_up: | | [src/common.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvbW1vbi5qbA==) | `92.72% <93.54%> (-0.38%)` | :arrow_down: | | [src/lodf\_calculations.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2xvZGZfY2FsY3VsYXRpb25zLmps) | `78.74% <93.75%> (+2.82%)` | :arrow_up: | | [src/radial\_braches.jl](https://app.codecov.io/gh/NREL-Sienna/PowerNetworkMatrices.jl/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL3JhZGlhbF9icmFjaGVzLmps) | `86.04% <77.55%> (-9.79%)` | :arrow_down: |
jd-lara commented 9 months ago

@alefcastelli I made some improvements to the RadialBranches code for the integration with PowerSimulations.jl. One test for the PTDF seems to be failing but it isn't clear why. I think that the test is written in a way that the indexing doesn't work as expected.