search

NREL-Sienna / PowerSimulations.jl

Julia for optimization simulation and modeling of PowerSystems. Part of the Scalable Integrated Infrastructure Planning Initiative at the National Renewable Energy Lab.
https://www.nrel.gov/analysis/sienna.html
BSD 3-Clause "New" or "Revised" License
279 stars 53 forks source link

Export opt model setting #1141

Closed jd-lara closed 3 weeks ago

jd-lara commented 3 weeks ago

This looks okay.

Are we fine keeping the name of the functions to be serialize_problem rather than export_problem?

IMO is fine, serialize is not exported.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.93%. Comparing base (f7e83f4) to head (2b45701). Report is 10 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141/graphs/tree.svg?width=650&height=150&src=pr&token=eEFWyojck4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #1141 +/- ## ========================================== + Coverage 77.89% 77.93% +0.03% ========================================== Files 118 118 Lines 12700 12707 +7 ========================================== + Hits 9893 9903 +10 + Misses 2807 2804 -3 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `77.93% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/core/settings.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141?src=pr&el=tree&filepath=src%2Fcore%2Fsettings.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvcmUvc2V0dGluZ3Muamw=) | `93.15% <100.00%> (+0.09%)` | :arrow_up: | | [src/operation/decision\_model.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141?src=pr&el=tree&filepath=src%2Foperation%2Fdecision_model.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL29wZXJhdGlvbi9kZWNpc2lvbl9tb2RlbC5qbA==) | `91.27% <100.00%> (ø)` | | | [src/operation/emulation\_model.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141?src=pr&el=tree&filepath=src%2Foperation%2Femulation_model.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL29wZXJhdGlvbi9lbXVsYXRpb25fbW9kZWwuamw=) | `86.00% <100.00%> (ø)` | | | [src/operation/operation\_model\_interface.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1141?src=pr&el=tree&filepath=src%2Foperation%2Foperation_model_interface.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL29wZXJhdGlvbi9vcGVyYXRpb25fbW9kZWxfaW50ZXJmYWNlLmps) | `79.35% <100.00%> (+1.54%)` | :arrow_up: |