Jd/multiple fixes

[jd-lara]

fixes #1133 fixes #1140 fixes #1129 fixes #1116 fixes #1148 fixes #1151

[github-actions[bot]]

Performance Results	Version	Precompile Time
Main	3.457935701
This Branch	3.429204504

Version	Build Time
Main-Build Time Precompile	52.869177408
Main-Build Time Postcompile	1.073056629
This Branch-Build Time Precompile	55.452417224
This Branch-Build Time Postcompile	1.030458564

Version	Build Time
Main-Solve Time Precompile	1349.64815289
Main-Solve Time Postcompile	1326.468863861
This Branch-Solve Time Precompile	1412.209291008
This Branch-Solve Time Postcompile	1378.233724082

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 50.43860% with 226 lines in your changes missing coverage. Please review.

Project coverage is 78.44%. Comparing base (f7e83f4) to head (88dfd7f). Report is 30 commits behind head on main.

Files with missing lines	Patch %	Lines
...rc/parameters/update_container_parameter_values.jl	34.76%	137 Missing :warning:
src/parameters/update_cost_parameters.jl	0.00%	60 Missing :warning:
...devices_models/devices/common/add_to_expression.jl	38.46%	8 Missing :warning:
.../operation/operation_model_simulation_interface.jl	65.00%	7 Missing :warning:
src/core/optimization_container.jl	44.44%	5 Missing :warning:
src/initial_conditions/add_initial_condition.jl	84.61%	4 Missing :warning:
...ices_models/devices/common/duration_constraints.jl	86.66%	2 Missing :warning:
src/parameters/update_parameters.jl	33.33%	2 Missing :warning:
src/utils/jump_utils.jl	83.33%	1 Missing :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #1145 +/- ## ========================================== + Coverage 77.89% 78.44% +0.55% ========================================== Files 118 121 +3 Lines 12700 12793 +93 ========================================== + Hits 9893 10036 +143 + Misses 2807 2757 -50 ``` | [Flag](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | `78.44% <50.43%> (+0.55%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/PowerSimulations.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2FPowerSimulations.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL1Bvd2VyU2ltdWxhdGlvbnMuamw=) | `100.00% <ø> (ø)` | | | [src/core/initial\_conditions.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Fcore%2Finitial_conditions.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvcmUvaW5pdGlhbF9jb25kaXRpb25zLmps) | `57.44% <ø> (ø)` | | | [src/core/settings.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Fcore%2Fsettings.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2NvcmUvc2V0dGluZ3Muamw=) | `93.15% <100.00%> (+0.09%)` | :arrow_up: | | [...s\_models/device\_constructors/branch\_constructor.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Fdevices_models%2Fdevice_constructors%2Fbranch_constructor.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldmljZXNfbW9kZWxzL2RldmljZV9jb25zdHJ1Y3RvcnMvYnJhbmNoX2NvbnN0cnVjdG9yLmps) | `83.33% <ø> (+2.83%)` | :arrow_up: | | [...models/devices/common/objective\_function/common.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Fdevices_models%2Fdevices%2Fcommon%2Fobjective_function%2Fcommon.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldmljZXNfbW9kZWxzL2RldmljZXMvY29tbW9uL29iamVjdGl2ZV9mdW5jdGlvbi9jb21tb24uamw=) | `88.77% <100.00%> (+0.35%)` | :arrow_up: | | [...ls/devices/common/objective\_function/market\_bid.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Fdevices_models%2Fdevices%2Fcommon%2Fobjective_function%2Fmarket_bid.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldmljZXNfbW9kZWxzL2RldmljZXMvY29tbW9uL29iamVjdGl2ZV9mdW5jdGlvbi9tYXJrZXRfYmlkLmps) | `36.42% <ø> (+1.73%)` | :arrow_up: | | [.../devices\_models/devices/common/range\_constraint.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Fdevices_models%2Fdevices%2Fcommon%2Frange_constraint.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldmljZXNfbW9kZWxzL2RldmljZXMvY29tbW9uL3JhbmdlX2NvbnN0cmFpbnQuamw=) | `74.71% <100.00%> (+3.53%)` | :arrow_up: | | [src/devices\_models/devices/thermal\_generation.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Fdevices_models%2Fdevices%2Fthermal_generation.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2RldmljZXNfbW9kZWxzL2RldmljZXMvdGhlcm1hbF9nZW5lcmF0aW9uLmps) | `85.00% <100.00%> (-0.55%)` | :arrow_down: | | [src/operation/decision\_model.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Foperation%2Fdecision_model.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL29wZXJhdGlvbi9kZWNpc2lvbl9tb2RlbC5qbA==) | `92.59% <100.00%> (+1.31%)` | :arrow_up: | | [src/operation/emulation\_model.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree&filepath=src%2Foperation%2Femulation_model.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL29wZXJhdGlvbi9lbXVsYXRpb25fbW9kZWwuamw=) | `86.40% <100.00%> (+0.40%)` | :arrow_up: | | ... and [14 more](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/NREL-Sienna/PowerSimulations.jl/pull/1145/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)

[jd-lara]

@rodrigomha I have to add a test for that case to and fix StorageSystemsSimulations.jl