NREL-Sienna / PowerSimulationsDynamics.jl

Julia package to run Dynamic Power System simulations. Part of the Scalable Integrated Infrastructure Planning Initiative at the National Renewable Energy Lab.
https://nrel-sienna.github.io/PowerSimulationsDynamics.jl/stable/
BSD 3-Clause "New" or "Revised" License
177 stars 42 forks source link

DNMY Add branch flow series results #255

Closed rodrigomha closed 2 years ago

rodrigomha commented 2 years ago

We eventually need to test this in PSS/e.

To do: nodal results from branches

github-actions[bot] commented 2 years ago
Performance Results Version Precompile Time
Master 7.917569635
This Branch 7.91199815
Version Run Time
Master-Build ResidualModel 9.611672756
Master-Execute ResidualModel 46.581571143
Master-Build MassMatrixModel 5.628591959
Master-Execute MassMatrixModel 42.41973026
This Branch-Build ResidualModel 8.499290102
This Branch-Execute ResidualModel 47.021250463
This Branch-Build MassMatrixModel 5.592164128
This Branch-Execute MassMatrixModel 42.604524065

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

codecov[bot] commented 2 years ago

Codecov Report

Merging #255 (21d042b) into master (c2a874e) will increase coverage by 0.02%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   90.20%   90.22%   +0.02%     
==========================================
  Files          65       65              
  Lines        6464     6406      -58     
==========================================
- Hits         5831     5780      -51     
+ Misses        633      626       -7     
Flag Coverage Δ
unittests 90.22% <80.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/base/simulation_results.jl 68.36% <80.00%> (+5.68%) :arrow_up:
src/base/simulation_model.jl 0.00% <0.00%> (-100.00%) :arrow_down:
src/base/small_signal.jl 80.80% <0.00%> (-1.60%) :arrow_down:
src/base/simulation.jl 89.55% <0.00%> (-1.05%) :arrow_down:
src/base/device_wrapper.jl 83.93% <0.00%> (-0.41%) :arrow_down:
src/base/simulation_initialization.jl 84.07% <0.00%> (-0.23%) :arrow_down:
src/base/jacobian.jl 95.58% <0.00%> (-0.19%) :arrow_down:
src/base/perturbations.jl 58.42% <0.00%> (-0.15%) :arrow_down:
src/models/device.jl 93.78% <0.00%> (-0.04%) :arrow_down:
src/initialization/init_device.jl 97.70% <0.00%> (-0.02%) :arrow_down:
... and 13 more
jd-lara commented 2 years ago

@rodrigomha I will close this pr to implement correctly later. It also needs to solve some conflicts.