NREL-Sienna / PowerSimulationsDynamics.jl

Julia package to run Dynamic Power System simulations. Part of the Scalable Integrated Infrastructure Planning Initiative at the National Renewable Energy Lab.
https://nrel-sienna.github.io/PowerSimulationsDynamics.jl/stable/
BSD 3-Clause "New" or "Revised" License
177 stars 42 forks source link

Mb/post processing frequency #279

Closed m-bossart closed 2 years ago

m-bossart commented 2 years ago

Add get_frequency_series for dynamic devices. The VOC inverter assumes ω_sys = 1.0 because ω_sys is not available in the simulation result?

github-actions[bot] commented 2 years ago
Performance Results Version Precompile Time
Master 11.860242293
This Branch 11.904338208
Version Run Time
Master-Build ResidualModel 11.731753734
Master-Execute ResidualModel 65.351724754
Master-Build MassMatrixModel 1.27791825
Master-Execute MassMatrixModel 56.937502086
This Branch-Build ResidualModel 12.124689929
This Branch-Execute ResidualModel 66.639176451
This Branch-Build MassMatrixModel 1.452634327
This Branch-Execute MassMatrixModel 58.360422056

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

codecov[bot] commented 2 years ago

Codecov Report

Merging #279 (5b8ba07) into master (df1c1c0) will increase coverage by 0.70%. The diff coverage is 97.91%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279/graphs/tree.svg?width=650&height=150&src=pr&token=Af8jhDz6u9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP)](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP) ```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================== + Coverage 89.91% 90.62% +0.70% ========================================== Files 63 63 Lines 7110 7104 -6 ========================================== + Hits 6393 6438 +45 + Misses 717 666 -51 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `90.62% <97.91%> (+0.70%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP) | Coverage Δ | | |---|---|---| | [src/base/simulation\_results.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL2Jhc2Uvc2ltdWxhdGlvbl9yZXN1bHRzLmps) | `67.50% <88.88%> (+1.00%)` | :arrow_up: | | [src/post\_processing/post\_proc\_generator.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL3Bvc3RfcHJvY2Vzc2luZy9wb3N0X3Byb2NfZ2VuZXJhdG9yLmps) | `100.00% <100.00%> (ø)` | | | [src/post\_processing/post\_proc\_inverter.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL3Bvc3RfcHJvY2Vzc2luZy9wb3N0X3Byb2NfaW52ZXJ0ZXIuamw=) | `94.33% <100.00%> (+2.79%)` | :arrow_up: | | [src/models/device.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL21vZGVscy9kZXZpY2Uuamw=) | `94.18% <0.00%> (-0.39%)` | :arrow_down: | | [src/base/simulation.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL2Jhc2Uvc2ltdWxhdGlvbi5qbA==) | `87.80% <0.00%> (+0.84%)` | :arrow_up: | | [src/base/perturbations.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/279/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL2Jhc2UvcGVydHVyYmF0aW9ucy5qbA==) | `58.57% <0.00%> (+9.17%)` | :arrow_up: |