search

NREL-Sienna / PowerSimulationsDynamics.jl

Julia package to run Dynamic Power System simulations. Part of the Scalable Integrated Infrastructure Planning Initiative at the National Renewable Energy Lab.
https://nrel-sienna.github.io/PowerSimulationsDynamics.jl/stable/
BSD 3-Clause "New" or "Revised" License
177 stars 42 forks source link

Update DERA output and minor fixes #302

Closed rodrigomha closed 1 year ago

rodrigomha commented 1 year ago

The change include an error for DynamicInjection cases.

github-actions[bot] commented 1 year ago
Performance Results Version Precompile Time
Master 10.045166857
This Branch 10.018774848
Version Run Time
Master-Build ResidualModel 8.313738172
Master-Execute ResidualModel 52.509160697
Master-Build MassMatrixModel 0.972340119
Master-Execute MassMatrixModel 44.613301994
This Branch-Build ResidualModel 8.154493507
This Branch-Execute ResidualModel 51.408030393
This Branch-Build MassMatrixModel 0.997965732
This Branch-Execute MassMatrixModel 44.109011082

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

codecov[bot] commented 1 year ago

Codecov Report

Merging #302 (dc76275) into master (30cc1fc) will increase coverage by 0.63%. The diff coverage is 92.72%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/302/graphs/tree.svg?width=650&height=150&src=pr&token=Af8jhDz6u9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP)](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP) ```diff @@ Coverage Diff @@ ## master #302 +/- ## ========================================== + Coverage 90.16% 90.80% +0.63% ========================================== Files 63 63 Lines 7637 7634 -3 ========================================== + Hits 6886 6932 +46 + Misses 751 702 -49 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `90.80% <92.72%> (+0.63%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP) | Coverage Δ | | |---|---|---| | [src/post\_processing/post\_proc\_generator.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/302/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL3Bvc3RfcHJvY2Vzc2luZy9wb3N0X3Byb2NfZ2VuZXJhdG9yLmps) | `98.74% <90.90%> (-0.98%)` | :arrow_down: | | [src/initialization/init\_device.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/302/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL2luaXRpYWxpemF0aW9uL2luaXRfZGV2aWNlLmps) | `96.83% <100.00%> (+<0.01%)` | :arrow_up: | | [src/models/device.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/302/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL21vZGVscy9kZXZpY2Uuamw=) | `94.32% <100.00%> (-0.12%)` | :arrow_down: | | [src/base/simulation.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/302/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL2Jhc2Uvc2ltdWxhdGlvbi5qbA==) | `87.80% <0.00%> (+0.84%)` | :arrow_up: | | [src/base/perturbations.jl](https://codecov.io/gh/NREL-SIIP/PowerSimulationsDynamics.jl/pull/302/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-SIIP#diff-c3JjL2Jhc2UvcGVydHVyYmF0aW9ucy5qbA==) | `59.02% <0.00%> (+9.02%)` | :arrow_up: |
rodrigomha commented 1 year ago

This change looks good. The DERA model is currently not fully complete --- the low and high voltage / frequency tripping and reconnection logic is not yet implemented. We had some discussion a while back and I think the conclusion was the capability did not yet exist to properly implement these timer based functionalities without major new features in PSID. Should there be a warning with this model? Should it be documented?

The warning that we currently have when constructing the Simulation is sufficient for now IMO