NREL-Sienna / PowerSimulationsDynamics.jl

Julia package to run Dynamic Power System simulations. Part of the Scalable Integrated Infrastructure Planning Initiative at the National Renewable Energy Lab.
https://www.nrel.gov/analysis/sienna.html
BSD 3-Clause "New" or "Revised" License
173 stars 42 forks source link

Fix for disable_timer_outputs #346

Closed m-bossart closed 1 year ago

m-bossart commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Merging #346 (471de96) into main (5796411) will increase coverage by 0.43%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/PowerSimulationsDynamics.jl/pull/346/graphs/tree.svg?width=650&height=150&src=pr&token=Af8jhDz6u9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/PowerSimulationsDynamics.jl/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #346 +/- ## ========================================== + Coverage 86.99% 87.42% +0.43% ========================================== Files 65 65 Lines 8664 8619 -45 ========================================== - Hits 7537 7535 -2 + Misses 1127 1084 -43 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `87.42% <100.00%> (+0.43%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/NREL-Sienna/PowerSimulationsDynamics.jl/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) | Coverage Δ | | |---|---|---| | [src/base/simulation.jl](https://app.codecov.io/gh/NREL-Sienna/PowerSimulationsDynamics.jl/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#diff-c3JjL2Jhc2Uvc2ltdWxhdGlvbi5qbA==) | `93.30% <100.00%> (+1.39%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/NREL-Sienna/PowerSimulationsDynamics.jl/pull/346/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)
github-actions[bot] commented 1 year ago
Performance Results Version Precompile Time
Main 5.223912328
This Branch 5.238405931
Version Run Time
Main-Build ResidualModel 13.340940484
Main-Execute ResidualModel 34.662727625
Main-Build MassMatrixModel 1.147260331
Main-Execute MassMatrixModel 361.503381802
This Branch-Build ResidualModel 13.070988115
This Branch-Execute ResidualModel 35.820242166
This Branch-Build MassMatrixModel 1.216337583
This Branch-Execute MassMatrixModel 363.821898643

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests