NREL-Sienna / PowerSimulationsDynamics.jl

Julia package to run Dynamic Power System simulations. Part of the Scalable Integrated Infrastructure Planning Initiative at the National Renewable Energy Lab.
https://nrel-sienna.github.io/PowerSimulationsDynamics.jl/stable/
BSD 3-Clause "New" or "Revised" License
177 stars 42 forks source link

fix docs issues #349

Closed rodrigomha closed 1 year ago

rodrigomha commented 1 year ago

Closes #344 and #342

codecov[bot] commented 1 year ago

Codecov Report

Merging #349 (6f6deaf) into main (f50405c) will decrease coverage by 0.02%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NREL-Sienna/PowerSimulationsDynamics.jl/pull/349/graphs/tree.svg?width=650&height=150&src=pr&token=Af8jhDz6u9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)](https://app.codecov.io/gh/NREL-Sienna/PowerSimulationsDynamics.jl/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna) ```diff @@ Coverage Diff @@ ## main #349 +/- ## ========================================== - Coverage 87.49% 87.48% -0.02% ========================================== Files 65 65 Lines 8619 8619 ========================================== - Hits 7541 7540 -1 - Misses 1078 1079 +1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `87.48% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/NREL-Sienna/PowerSimulationsDynamics.jl/pull/349/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL-Sienna)
github-actions[bot] commented 1 year ago
Performance Results Version Precompile Time
Main 4.729937233
This Branch 5.175678546
Version Run Time
Main-Build ResidualModel 12.065893326
Main-Execute ResidualModel 32.808683185
Main-Build MassMatrixModel 1.038082306
Main-Execute MassMatrixModel 430.180844783
This Branch-Build ResidualModel 11.792215608
This Branch-Execute ResidualModel 31.609173024
This Branch-Build MassMatrixModel 1.016031026
This Branch-Execute MassMatrixModel 435.394813465

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests