NREL-Sienna / PowerSimulationsDynamics.jl

Julia package to run Dynamic Power System simulations. Part of the Scalable Integrated Infrastructure Planning Initiative at the National Renewable Energy Lab.
https://www.nrel.gov/analysis/sienna.html
BSD 3-Clause "New" or "Revised" License
173 stars 42 forks source link

Typos in documents: LCL Filter state-space model reference frame should be on the dq0 axis. #356

Closed XingyuCiao closed 8 months ago

XingyuCiao commented 10 months ago

Hi! The correct model should be: LCL-ss

rodrigomha commented 10 months ago

Hi, is the only difference that we use R and I instead of DQ? This is just a convention that we use to refer to the reference frame of the network as RI instead of the internal reference frames of dq used for devices.

XingyuCiao commented 10 months ago

Hi, is the only difference that we use R and I instead of DQ? This is just a convention that we use to refer to the reference frame of the network as RI instead of the internal reference frames of dq used for devices.

Hi, that makes sense to me. Just one more small typo, for eq(1e) and (1f), the filter current i_r and i_i should be used instead of converter current i_r,cv and i_i,cv.

rodrigomha commented 10 months ago

Hi, is the only difference that we use R and I instead of DQ? This is just a convention that we use to refer to the reference frame of the network as RI instead of the internal reference frames of dq used for devices.

Hi, that makes sense to me. Just one more small typo, for eq(1e) and (1f), the filter current i_r and i_i should be used instead of converter current i_r,cv and i_i,cv.

Thanks for this. I'll fix this typo in the next release!

jd-lara commented 8 months ago

@rodrigomha can we fix this for the 0.13 release?