search

NREL-Sienna / PowerSimulationsDynamics.jl

Julia package to run Dynamic Power System simulations. Part of the Scalable Integrated Infrastructure Planning Initiative at the National Renewable Energy Lab.
https://nrel-sienna.github.io/PowerSimulationsDynamics.jl/stable/
BSD 3-Clause "New" or "Revised" License
175 stars 42 forks source link

Fixes a bug when calling Jacobian for a system with delays #382

Closed m-bossart closed 4 months ago

m-bossart commented 4 months ago

Added a test for getting the Jacobian with sparse_retrive_loop >0 which would have hit this bug.

Can use this system when ready instead of manually building the system: NREL-Sienna/PowerSystemCaseBuilder.jl#99

github-actions[bot] commented 4 months ago
Performance Results Version Precompile Time
Main 1.782403514
This Branch 1.839369475
Version Run Time
Main-Build ResidualModel 7.075743169
Main-Execute ResidualModel 15.73975068
Main-Build MassMatrixModel 0.555546667
Main-Execute MassMatrixModel 29.41714623
This Branch-Build ResidualModel 7.084980049
This Branch-Execute ResidualModel 15.370334084
This Branch-Build MassMatrixModel 0.552499739
This Branch-Execute MassMatrixModel 29.367739027

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests