search

NREL / BuildingMOTIF

Building Metadata OnTology Interoperability Framework (BuildingMOTIF). For models, see https://models.open223.info/
https://buildingmotif.readthedocs.io/
Other
49 stars 7 forks source link

Add templates for common systems #115

Closed gtfierro closed 2 years ago

gtfierro commented 2 years ago

Starting to translate Selam's work on modeling a building in 223P into some templates.

One question: I have a script that uses the templates to programmatically generate an example building without user input. Would you all be ok with a "models/" folder which stores generation scripts for specific buildings? We can include this as part of the integration testing.

Added a new notebook demonstrating creation + validation of a 223P model. It currently fails, but I'm working on it!

Merge after #130 and #113 (will reduce the diffs -- just look in Libraries and Notebooks for now)

gtfierro commented 2 years ago
  • Should we move the 223p/ dir under ashrae/?

Great idea! done

  • Should we rename nrel-templates/ => nrel/?

I think we may keep shapes in a separate folder, e.g. for different sites. I like having this library explicitly consist of templates.

  • Should we rename connections.yml to connection_points.yml, or do you envision adding other 223 concepts?

There's technically a Duct in there, so it should be connections and connection points

  • Should we consider separating the devices-and-systems.yml into devices.yml and systems.yml files to reduce the size of a combined one? I could see this combined file getting quite large, but not sure if we currently have a way for one yml file to access another.

Great idea, and done