Closed gtfierro closed 1 year ago
There's a subtle logic bug in here that is causing the tests to fail; I'm anticipating a relatively minor change to the code, but feel free to hold off on review for a day
I don't have any issues with this PR. Do we think the tests will be fixed by the other PR being merged?
They won't be, I don't think. There's a subtle issue with dependencies more than 1 'hop' away that I'm still trying to fix
Logic bug is fixed as discussed on the call today -- this is ready for review!
Fixes #203 and #237
Cleans up template evaluation with some more utility functions (all tested), and some additional comments. Also adds a few tests to cover untested edge cases in template evaluation. Fixes behavior around inlining dependencies with optional arguments (#237)