Closed gtfierro closed 1 year ago
@gtfierro I'm not sure I understand, the tests are still failing?
My understanding during the meeting today is you said this test was supposed to be failing? I can fix it if you want in this PR but I just addressed the issue we spoke about
None of the tests should fail. Some of the tests should 4XX as they test the error case, but they shouldn't fail.
test_evaluate_ingress
should not fail nor 4XX.
> assert (MODEL["cav1"], A, BRICK.CAV) in graph
E AssertionError: assert (rdflib.term.URIRef('urn:my_model/cav1'), rdflib.term.URIRef('http://www.w3.org/1999/02/22-rdf-syntax-ns#type'), rdflib.term.URIRef('https://brickschema.org/schema/Brick#CAV')) in <Graph identifier=N366f3eeaeaf14a70a73c772c7ab2254a (<class 'rdflib.graph.Graph'>)>
Should be fixed now! Famous last words...
I'll re-request review when it's done
@haneslinger the tests seem to be passing now -- take a look when you have a chance!
nice, thank you. opened for reals here
To be fixed in #244
Two fixes:
MODEL = Namespace('urn:model/')
, you can create the URIurn:model/abc
just by usingMODEL['abc']
.urn:building/
)This also contains the latest commits from
develop