search

NREL / BuildingMOTIF

Building Metadata OnTology Interoperability Framework (BuildingMOTIF)
https://buildingmotif.readthedocs.io/
Other
48 stars 6 forks source link

Hannah eval ingress #244

Closed haneslinger closed 1 year ago

haneslinger commented 1 year ago
image
gtfierro commented 1 year ago

I'm having a hard time testing this because I keep running into that database migration error on the deps_association table that we talked about awhile ago. Do you get this locally too, or is there a particular process you use to set up the DB? I'm just using the docker compose file we have

haneslinger commented 1 year ago

I'm having a hard time testing this because I keep running into that database migration error on the deps_association table that we talked about awhile ago. Do you get this locally too, or is there a particular process you use to set up the DB? I'm just using the docker compose file we have

I'm not having these issues and am having trouble remembering... can you elaborate?

gtfierro commented 1 year ago

https://github.com/NREL/BuildingMOTIF/pull/247 addresses the issue that I'm running into -- I should be able to use that to test this PR early next week

gtfierro commented 1 year ago

@haneslinger I'm finally getting around to this (so sorry! Travel put me behind on everything). Is the "choose file" dialog intended to let me upload a CSV file for evaluating the template? (I'm referring to hitting the Template evaluation endpoint code path)? When I upload a CSV file using the new interface, I get these errors:

Screenshot 2023-06-12 at 8 00 11 PM

The final error suggests to me that maybe the CSV file is being added to the graph directly (and then it is complaining about incorrect syntax) rather than put through the template evaluation endpoint.

The CSV file itself is just:

name
def
zyx

I tried reading through the code to see how the template evaluation code was invoked. I think that the file is uploaded to the template evaluation endpoint and the graph is stored in a evaluatedGraph variable, but then this value is never used again. Can you take a look?

haneslinger commented 1 year ago

The final error suggests to me that maybe the CSV file is being added to the graph directly (and then it is complaining about incorrect syntax) rather than put through the template evaluation endpoint.

I am not getting this error nor am I trying to add the csv to the graph directly (note /templates/861/evaluate/ingress?model_id=3 was called, which does not modify anything in the db.)

image

Could you look at the api logs and get a stack trace for your error?