search

NREL / BuildingMOTIF

Building Metadata OnTology Interoperability Framework (BuildingMOTIF)
https://buildingmotif.readthedocs.io/
Other
48 stars 6 forks source link

Remove configs.py #256

Closed haneslinger closed 1 year ago

haneslinger commented 1 year ago

We dont need this anymore, we've got .env

TShapinsky commented 1 year ago
  1. Provide a couple of examples for loading env variables on windows/linux/mac
  2. Link to python-dotenv as a possible way to load from .env cleanly
haneslinger commented 1 year ago

@MatthewSteen re-pinging this.

MatthewSteen commented 1 year ago

@haneslinger I think this just needs some brief documentation about the BASH requirement to run on Windows. See my comments and suggestions above, specifically https://github.com/NREL/BuildingMOTIF/pull/256#discussion_r1228638226.

Looking at this a bit more, I think it just requires a Windows user to use bash, which is included with Git. So maybe just keep as is and note that in the docs, which we could revisit later. The python-dotenv solution could be clean but I generally don't like adding dependencies if they can be avoided.

haneslinger commented 1 year ago

@MatthewSteen Oh, yes, thank you. Would you be able to add that? Do you want it in this PR?

MatthewSteen commented 1 year ago

@haneslinger I added a note for windows users, which I think is sufficient for now. Take a look and merge when ready.