NREL / BuildingMOTIF

Building Metadata OnTology Interoperability Framework (BuildingMOTIF)
https://buildingmotif.readthedocs.io/
Other
42 stars 6 forks source link

Add ability to use TopQuadrant SHACL implementation as engine #308

Closed gtfierro closed 3 months ago

gtfierro commented 4 months ago
gtfierro commented 4 months ago

@MatthewSteen @TShapinsky where do you think I should document the two different SHACL engines? Under "explanations" in the docs?

TShapinsky commented 4 months ago

@gtfierro What is the reason to drop support for python 3.8? It's still fairly modern (2019) and is the default python for ubuntu 20.04 which is still used by a lot of people. I'd prefer not to drop support unless we have to.

gtfierro commented 4 months ago

@gtfierro What is the reason to drop support for python 3.8? It's still fairly modern (2019) and is the default python for ubuntu 20.04 which is still used by a lot of people. I'd prefer not to drop support unless we have to.

I thought that our dependencies (rdflib 7, for example) had dropped 3.8 but they only dropped 3.8.0! I've changed this so it's compatible with 3.8.1 or higher

TShapinsky commented 4 months ago

@gtfierro What is the reason to drop support for python 3.8? It's still fairly modern (2019) and is the default python for ubuntu 20.04 which is still used by a lot of people. I'd prefer not to drop support unless we have to.

I thought that our dependencies (rdflib 7, for example) had dropped 3.8 but they only dropped 3.8.0! I've changed this so it's compatible with 3.8.1 or higher

Cool! That seems good to me, I doubt anyone is using 3.8.0

gtfierro commented 4 months ago

@TShapinsky this should be ready for review now!

gtfierro commented 3 months ago

@TShapinsky can you approve when you get a chance? thanks!

MatthewSteen commented 3 months ago

@MatthewSteen @TShapinsky where do you think I should document the two different SHACL engines? Under "explanations" in the docs?

Probably explanation (understanding-oriented) or reference (information-oriented), which might be a better fit.