fix tests for windows - Githubissues

NREL / BuildingMOTIF

Building Metadata OnTology Interoperability Framework (BuildingMOTIF)

https://buildingmotif.readthedocs.io/

Other

42 stars 6 forks source link

fix tests for windows #318

Open dllliu opened 2 months ago

dllliu commented 2 months ago

Add delete=false parameter to temporary file objects in order to fix permission denied errors when running unit tests for windows and flush buffer in memory after data is written and before new data is written in order to fix invalid zip file errors

gtfierro commented 2 weeks ago

@MatthewSteen you develop mostly on Windows, right? Can you give this a test on your machine to see if it works?

MatthewSteen commented 2 weeks ago

@MatthewSteen you develop mostly on Windows, right? Can you give this a test on your machine to see if it works?

Windows machine, but this repo in on the Ubuntu 22 side. I'll take a look.

MatthewSteen commented 2 weeks ago

Passes on WSL but I'm not sure if that confirms anything. I think if it passes on Daniel's Windows machine (not WSL), then the issue could be considered fixed.