search

NREL / BuildingMOTIF

Building Metadata OnTology Interoperability Framework (BuildingMOTIF). For models, see https://models.open223.info/
https://buildingmotif.readthedocs.io/
Other
50 stars 7 forks source link

fix CD action to publish to pypi once per release #356

Closed MatthewSteen closed 1 month ago

MatthewSteen commented 1 month ago

Fix #285.

TShapinsky commented 1 month ago

This looks good, the only comment I have is that since the docs with release and docs without are completely separate it might make sense to just split it into two files so we don't have the conditionals on each job.

MatthewSteen commented 1 month ago

This looks good, the only comment I have is that since the docs with release and docs without are completely separate it might make sense to just split it into two files so we don't have the conditionals on each job.

Yeah, I've thought about that too. I think we could do that in another PR later if we want to go in that direction. When I originally created the cd.yml I was trying to consolidate all the CD related action in one file. Same goes for the ci.yml, which I'd like to revisit later.

MatthewSteen commented 1 month ago

Here's what the CD action does on a release now...

https://github.com/NREL/BuildingMOTIF/actions/runs/11373850305