NREL / ComStock

National scale modeling of the U.S. commercial building stock supported by U.S. DOE, LADWP, and others and maintained by NREL
Other
29 stars 7 forks source link

Warehouse thermostats and HVAC systems #118

Closed eringold closed 7 months ago

eringold commented 7 months ago

Pull request overview

Pull Request Author

This pull request makes changes to (select all the apply):

Author pull request checklist:

Review Checklist

This will not be exhaustively relevant to every PR.

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.
eringold commented 7 months ago

@mdahlhausen

One issue which we discussed is that this will change the thermostat values for offices spaces. Not great, but this fix is far better even though it does reset office temperatures.

I don't allow a reduction of warehouse building heating setpoints, which only applies to warehouse office spaces: https://github.com/NREL/ComStock/blob/84d46c8a7397b17054cf0375cbce30be6f5f709b/resources/measures/add_thermostat_setpoint_variability/measure.rb#L308-L315