Measure unit test fixes

eringold commented 8 months ago

Pull request overview

Fixes failing tests for:

ChangeBuildingLocation
upgrade_env_roof_insulation_aedg
EnvStormWindowsTest (measure did not exist)
upgrade_hvac_economizer

Pull Request Author

This pull request makes changes to (select all the apply):

[ ] Documentation
[ ] Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
[ ] Sampling
[ ] Workflow Measures
[x] Upgrade Measures
[ ] Reporting Measures
[ ] Postprocessing

Author pull request checklist:

[ ] Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
[ ] Added tests for new measures
[x] Updated measure .xml(s)
[ ] Register values added to comstock_column_definitions.csv
[ ] Both options_lookup.tsv files updated
[ ] 10k+ test run
[ ] Change documentation written
[ ] Measure documentation written
[ ] ComStock documentation updated
[ ] Changes reflected in example .yml files
[ ] Changes reflected in README.md files
[ ] Added 'See ComStock License' language to first two lines of each code file
[ ] Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
[x] All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

[x] Perform a code review on GitHub
[x] All related changes have been implemented: data and method additions, changes, tests
[x] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
[ ] Reviewed change documentation
[ ] Ensured code files contain License reference
[ ] Results differences are reasonable
[ ] Make sure the newly added measures has been added with tests and indexed properly
[ ] CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

eringold commented 8 months ago

@mdahlhausen: @ChristopherCaradonna claimed upgrade_env_new_aedg_windows, I just updated the xml because I deleted the erroneously-placed EnvStormWindowsTest from that measure's test dir.

Re: hvac_economizer_test, I see all tests passing with OS 3.7.0, using openstudio cli: ... Which test did you see failing? Were you running with system Ruby or with openstudio?

mdahlhausen commented 7 months ago

@eringold it runs in 3.7, not 3.6.1. good to merge since we are running ComStock with OS 3.7

NREL / ComStock