You will notice the run resources measure tests report as success but actually it cannot Archiving artifacts due to rake execution aborted.
This PR is basically fix this issue by:
Update the resource_measure_test.txt
Go through the measures under /resource/ and import the ../../../../test/helpers/minitest_helper if it hasn't been done to support generating junit xml report.
Fixes #ISSUENUMBERHERE (IF RELEVANT)
Pull Request Author
This pull request makes changes to (select all the apply):
[x] Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
[ ] Added tests for new measures
[ ] Updated measure .xml(s)
[ ] Register values added to comstock_column_definitions.csv
[ ] Both options_lookup.tsv files updated
[ ] 10k+ test run
[ ] Change documentation written
[ ] Measure documentation written
[ ] ComStock documentation updated
[ ] Changes reflected in example .yml files
[ ] Changes reflected in README.md files
[ ] Added 'See ComStock License' language to first two lines of each code file
[x] Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
[ ] All new and existing tests pass the CI
Review Checklist
This will not be exhaustively relevant to every PR.
[ ] Perform a code review on GitHub
[ ] All related changes have been implemented: data and method additions, changes, tests
[ ] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
[ ] Reviewed change documentation
[ ] Ensured code files contain License reference
[ ] Results differences are reasonable
[ ] Make sure the newly added measures has been added with tests and indexed properly
[ ] CI status: all tests pass
ComStock Licensing Language - Add to Beginning of Each Code File
# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.
Since some of the measure under resources/ has been renamed and hasn't been updated in the resource_measure_test.txt . (for example: https://github.com/NREL/ComStock/commit/dfd5efe699a47cb17755ad8d4f57675123c60420) And some new measure test has been added without import the test_helper(for example: https://github.com/NREL/ComStock/blame/main/resources/measures/create_typical_building_from_model/tests/test_hvac.rb) the measure test result cannot be executed correctly in docker and ci, the missing file in the resource_measure_test.txt will cause the rake test cannot continue since it cannot find the file. For example: https://ci.openstudio.net/blue/organizations/jenkins/comstock-internal/detail/main/33/pipeline/49
You will notice the
run resources measure tests
report as success but actually it cannot Archiving artifacts due to rake execution aborted.This PR is basically fix this issue by:
Go through the measures under /resource/ and import the ../../../../test/helpers/minitest_helper if it hasn't been done to support generating junit xml report.
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File